Post Reply 

 
  • 3 Votes - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Major bug fixed
admin Offline
Administrator

Posts: 219
Joined: Jan 2012
Reputation: 175
*******
Post: #1
Major bug fixed
A major bug related to the display of attachments has been fixed. An immediate improvement in performance has been measured (via CPU resources) and observed.
June 30, 2016 11:57 pm
BrookeL Offline
-_-

Posts: 42
Joined: Jun 2012
Reputation: 76
**
Post: #2
RE: MAJOR BUG FIXED!
Image heavy threads are quick as lightning now. Thanks admin! Smile

Was this the issue where attachment thumbnails needed to be regenerated per request?
July 1, 2016 12:15 am
admin Offline
Administrator

Posts: 219
Joined: Jan 2012
Reputation: 175
*******
Post: #3
RE: MAJOR BUG FIXED!
It was a horrendous arrangement -- attachment.php, which deals with everything attachment-related, was executed for each and every thumbnail displayed to a user. Attachment.php contains 150 lines of code and queries the database multiple times. This script was being triggered thousands of times at a given time.

I spent so much time trying to circumvent this issue and it's finally fixed. The array that's loaded by the script handling threads is used to determine thumbnail image paths instead of executing attachment.php to then query the database to then determine the path of the thumbnail image.
July 1, 2016 12:18 am
BrookeL Offline
-_-

Posts: 42
Joined: Jun 2012
Reputation: 76
**
Post: #4
RE: MAJOR BUG FIXED!
Crazy design oversight for this version of MyBB; crazy inefficient. I just assumed it was mostly my internet to blame, and didn't fully appreciate how bad it really was. Glad you found a fix though. Smile
July 1, 2016 12:48 am
[+] 1 user Likes BrookeL's post
sbflicker Offline
Posting Freak

Posts: 2,606
Joined: Apr 2013
Reputation: 8347
*****
Post: #5
RE: MAJOR BUG FIXED!
Seems to be running well now
July 1, 2016 2:28 am
[+] 1 user Likes sbflicker's post
admin Offline
Administrator

Posts: 219
Joined: Jan 2012
Reputation: 175
*******
Post: #6
RE: MAJOR BUG FIXED!
Thanks sbflicker! This issue has consumed a great deal of our time and energy (managing server performance) -- we're now free to make some fundamental improvements in the area of design and function (batch uploads being key).
July 1, 2016 2:33 am
[+] 1 user Likes admin's post
Mark Stretch Offline
Junior Member

Posts: 47
Joined: May 2013
Reputation: 84
**
Post: #7
RE: Major bug fixed
Wow! Dramatic improvement. Some threads were still not loading after many minutes, and now they're filling as fast as the thumbnails can be sent.
July 1, 2016 7:52 am
ghoolihan Offline
Shitposting Extraordinaire

Posts: 47
Joined: Jun 2013
Reputation: 44
**
Post: #8
RE: Major bug fixed
>attachment.php, which deals with everything attachment-related, was executed for each and every thumbnail displayed to a user.

Holy fuck. No wonder the site was strangled.
July 1, 2016 1:26 pm
admin Offline
Administrator

Posts: 219
Joined: Jan 2012
Reputation: 175
*******
Post: #9
RE: Major bug fixed
(July 1, 2016 1:26 pm)ghoolihan Wrote:  >attachment.php, which deals with everything attachment-related, was executed for each and every thumbnail displayed to a user.

Holy fuck. No wonder the site was strangled.

Absolutely. It's something I tried resolving by tinkering with elements of the script and eventually abandoned. After reaching out to the developers of MyBB, I was told that (a) it's not an issue or (b) it's not practical to address. In returning to some of my old threads, I discovered that my complaint had been flagged and incorporated into official development plans for MyBB 1.8 and MyBB 2.0 -- importantly, one of the key developers provided a very simple fix (which I didn't realize was possible and no one else suggested).
July 1, 2016 5:19 pm
[+] 2 users Like admin's post
Bellifull Offline
Junior Member

Posts: 33
Joined: Aug 2012
Reputation: 49
**
Post: #10
RE: Major bug fixed
Nice job! It's like a whole new site now!
July 3, 2016 11:22 pm
[+] 1 user Likes Bellifull's post
Post Reply 


Pregnant Cam Girls

Forum Jump:


User(s) browsing this thread: 1 Guest(s)